mvp18/UCDR

About args.trainvalid

Opened this issue · 3 comments

tiangarin commented

Thank you for your excellent work.
I notice that args.trainvalid exists in the domainnet.py, sketchy_extended.py and other datasets' script, but this argument does't exist in options_xxx.py.
Should I remove this argument, or set it True?

tiangarin commented

image
For original SAKE, it use all seen classes for training. What's about SAKE-512(our evaluation)? What's about SAKE-xxx-w/o Label*?

aisagarw commented

Thank you for your excellent work. I notice that args.trainvalid exists in the domainnet.py, sketchy_extended.py and other datasets' script, but this argument does't exist in options_xxx.py. Should I remove this argument, or set it True?

Did you figure it out finally? Stuck at the same doubt.

tiangarin commented

Thank you for your excellent work. I notice that args.trainvalid exists in the domainnet.py, sketchy_extended.py and other datasets' script, but this argument does't exist in options_xxx.py. Should I remove this argument, or set it True?

Did you figure it out finally? Stuck at the same doubt.

I just delete all args.trainvalid.

  • 👍1