mwh/dragon

name conflict

paperbenni opened this issue ยท 9 comments

The name of this conflicts with the kde media player also called dragon.
I guess you could just try to work without one of the two, but that's not good practice.
I suggest changing the executable name to something like xdragon, that would also fit with xclip or xdotool since they are also small x utilities. Or you could just rename the project as a whole. Maybe the change would also enable it to get into the repos of some distros.

mwh commented

Without really dealing with the project name itself at this stage, there is now a NAME Makefile variable that will rename everything when used, so make NAME=xdragon install will build the executable and man page accordingly, so it should be easier to rename when required. It's not included in a tagged release yet.

N-R-K commented

@dasJ Hi, I'm not too familiar with Nix so apologies if I got this wrong, but it seems like a package for this already exists on Nix named dragon-drop which is fetching the exact same commit.

For some background, I'm trying to package a git version of this for gentoo::guru and ran into the same problem of conflicting name with kde/dragon so I tried to look into what other distros are doing.

It seems like Guix is also using the dragon-drop name, and I'm leaning towards this as well. If we can agree on this name then I can contact the AUR maintainer to see if he'd be willing to rename as well for the sake of unification.

mwh commented

dragon-drop seems like a good disambiguating name, so I'll suggest that as something to unify on. make NAME=dragon-drop install will build everything that way. Changing the default seems like it may break things, but may be worthwhile anyway.

If you have packaged it up somewhere, let me know and I'll list them in the readme to save people the trouble of compiling it.

Hello, I'm the AUR maintainer. I originally named it dragon-drag-and-drop, but I think I just made the name up to avoid the conflict. I'm happy to change it to dragon-drop if you prefer @mwh. It's certainly a much better name than what I came up with! Looking forward, should I just keep using make NAME=dragon-drop?

N-R-K commented

should I just keep using make NAME=dragon-drop?

That will only work on the git version since NAME isn't on any release yet. But yes, dragon-drop sounds like a good name. At the moment on gentoo::guru it's still named dragon , so far no bug reports on it. I assume most kde users aren't the target audience for this. However if all other distros are switching to dragon-drop then I can get it changed to that as well.

mwh commented

I'll be honest, it's also a better name than what I came up with!

make NAME=dragon-drop will produce an executable and man page with that name, so if that's what you need it'll be slightly easier than manually fixing it up. You can do what you want or what the AUR requires, I'm just happy to bless this disambiguation for the coordination benefits and whatever that's worth.

I will cut a release soon that has this and other recent changes in it for those that need that.

Thank to you both! I'll wait until the next release then change both the stable and the -git packages. Yes, no problem at all to use NAME= from the packaging perspective. Cheers.

mwh commented

I have cut a new 1.2.0 release now with those additions.

Brilliant! Thanks @mwh. I've modified the AUR packages with the new names. Thanks again.