my-ugly-code/WebsUpTV

Hardcoded URL in plex.js

JamynShanley opened this issue · 2 comments

JamynShanley commented

WebsUpTV/services/plex.js

Line 72 in 65b4ba7

pipUrl: 'http://192.168.1.209:32400/web/index.html#!/server/'+payload.Server.uuid+'/details?key='+payload.Metadata.grandparentKey

Perhaps this should be updated to use a variable.

my-ugly-code commented

@JamynShanley You're 100% right. I'll get this changed now. Thanks so much for letting me know!

my-ugly-code commented

On further inspection, the pipUrl field was a remnant of an older solution, which used the actual PMS details page instead of the node-hosted page. I've removed the unused field and pushed a new version of plex.js to the repo. Users do not need to update, but this will keep future changes cleaner. Thanks again, marking this as closed.
4429ea3