Incompatible with GNOME 43
Opened this issue · 12 comments
Tested in Fedora 37 beta and forced it to run with metadata.json edit.
Does not work
Makes sense because the whole menu is redesigned in gnome 43 and has new audio options. Hopefully this can be updated soon enough as sadly the new audio options don't include this feature.
+1
Is this project still active?
Shame, this is a really good extension.
This does seem possible to do though - the main change with GNOME 43 is that it "removed aggregateMenu and uses quick settings (quickSettings) instead".
I'm playing around with it now in a GNOME sandbox, I've never worked with GJS before so I'm just trying to figure it out with the debugger. ApplicationStreamSlider should now extend imports.ui.quickSettings.QuickSlider and Main.panel.statusArea.aggregateMenu._volume.menu.addMenuItem(volumeMixer); should be something like Main.panel.statusArea.quickSettings._addItems(volumeMixer, 2);.. I think?
Again, never worked with extensions before. Guess I'll have to try to learn.
Sources: https://gjs.guide/extensions/upgrading/gnome-shell-43.html#quick-settings and https://gjs.guide/extensions/topics/quick-settings.html#slider
@james-still you are more than welcome to submit a PR. If I don't respond to a PR within a week or two, just ping me again.
Shame, this is a really good extension.
This does seem possible to do though - the main change with GNOME 43 is that it "removed aggregateMenu and uses quick settings (quickSettings) instead".
I'm playing around with it now in a GNOME sandbox, I've never worked with GJS before so I'm just trying to figure it out with the debugger.
ApplicationStreamSlidershould now extendimports.ui.quickSettings.QuickSliderandMain.panel.statusArea.aggregateMenu._volume.menu.addMenuItem(volumeMixer);should be something likeMain.panel.statusArea.quickSettings._addItems(volumeMixer, 2);.. I think?Again, never worked with extensions before. Guess I'll have to try to learn.
Sources: https://gjs.guide/extensions/upgrading/gnome-shell-43.html#quick-settings and https://gjs.guide/extensions/topics/quick-settings.html#slider
Maybe this can help you: https://github.com/qwreey75/quick-settings-tweaks
Shame, this is a really good extension.
This does seem possible to do though - the main change with GNOME 43 is that it "removed aggregateMenu and uses quick settings (quickSettings) instead".
I'm playing around with it now in a GNOME sandbox, I've never worked with GJS before so I'm just trying to figure it out with the debugger.ApplicationStreamSlidershould now extendimports.ui.quickSettings.QuickSliderandMain.panel.statusArea.aggregateMenu._volume.menu.addMenuItem(volumeMixer);should be something likeMain.panel.statusArea.quickSettings._addItems(volumeMixer, 2);.. I think?
Again, never worked with extensions before. Guess I'll have to try to learn.
Sources: https://gjs.guide/extensions/upgrading/gnome-shell-43.html#quick-settings and https://gjs.guide/extensions/topics/quick-settings.html#sliderMaybe this can help you: https://github.com/qwreey75/quick-settings-tweaks
Dang this is awesome, thanks!
I'm wondering if some of you have a fork where is developing, but it seems to be you are on the right way :)
Started looking at this last night.
Would it be better to use a separate menu or integrate with the main quick settings dropdown?
With the quick settings a ToggleMenu doesn't really make a lot of sense as we don't need the toggle aspect, what would be better to use here to provide the popup menu containing all the sliders?
can you extend the sound output device chooser menu that already exists?
forcing the extension now throws the following error: class heritage Volume$1.StreamSlider is not an object or null