myoung34/docker-github-actions-runner

Use modern socket in Kubernetes YAML sample

jrbe228 opened this issue · 1 comments

The sample K8s YAML mounts dockerd socket by default. Modern K8s has deprecated dockerd as a runtime since v1.20. Any users of this repo (such as me) on AKS/EKS/GKE would find the sample YAML failing. I recommend defaulting to containerd, as the inline comments mention. Only the path: and mountPath lines would need to change:

      ...
      volumes:
      - name: dockersock
        hostPath:
          path: /run/containerd/containerd.sock  # containerd socket

      containers:
      - name: runner
        ...
        volumeMounts:
        - name: dockersock
          mountPath: /run/containerd/containerd.sock # containerd socket
        ...

I went ahead and made the change, thanks