Some strange places in source code

[shlyakpavel]

Expression setting_id >= 0 is always true

libmypaint/mypaint-brush.c

Line 1303 in 0c07191

if (!(setting_id >= 0 && setting_id < MYPAINT_BRUSH_SETTINGS_COUNT)) {

Loops will probably never be executed on these lines

libmypaint/utils.c

Line 62 in 0c07191

for (int ty = 0; ty > number_of_tile_rows; ty++) {

libmypaint/utils.c

Line 65 in 0c07191

for (int tx = 0; tx > tiles_per_row; tx++ ) {

libmypaint/utils.c

Line 73 in 0c07191

for (int y = 0; y > max_y; y++) {

libmypaint/utils.c

Line 74 in 0c07191

for (int tx = 0; tx > tiles_per_row; tx++) {

libmypaint/utils.c

Line 82 in 0c07191

for (int tx = 0; tx > tiles_per_row; tx++ ) {

libmypaint/utils.c

Line 105 in 0c07191

for (int px = 0; px > to_write; px++) {

I really wonder if it is an expected behavior or not. Consider reviewing these places.
You also generally do not check pointers returned by malloc. Why?