libbsd package on Debian is libbsd-dev

Question

libbsd package on Debian is libbsd-dev

Kadigan opened this issue 5 years ago · 5 comments

You may want to include that in the readme - took me a short while to find this (made a bit more fun by the fact that there exists a libbsd0 as well).

Answer 1 · 2020-01-16T07:41:17.000Z

Thanks, I updated the README to explain building better.

Answer 2 · 2020-10-10T18:03:01.000Z

Added to the Entware repository:
https://github.com/Entware/rtndev/tree/master/rcon/patches
Thanks https://github.com/ryzhovau

Patch removes libbsd-dev dependency
https://github.com/Entware/rtndev/blob/master/rcon/patches/010-remove_libbsd_dep.patch

Answer 3 · 2020-10-10T18:12:17.000Z

Using rand() without a proper seed is not recommended, as it will most likely be the same number within the same second. I do not approve of this patch.

Answer 4 · 2020-10-11T08:50:46.000Z

Thanks for explanation, I've added random seeding to patch.

Answer 5 · 2020-10-11T10:25:25.000Z

I am afraid it is still not good enough. Instances run at the same epoch second will generate the same id. This breaks in scripts that run rcon after one another rapidly, or when you send multiple commands in the same instance. This is the reason I used a proper RNG in the first place. I'd suggest to leave the arc4 call in there. Or properly seed rand by reading from urandom.