n3integration/terraform-provider-godaddy

429's shouldn't be a hard error

polds opened this issue · 1 comments

polds commented

Me again :(

I'm working with a Terraform module that updates close to 200 domains using this, after awhile it begins to throw 429 - Too many requests from GoDaddy. I'm thinking the module should gracefully handle this and backoff as it's not a true error.

Providing my workload today, I'll see if I can get a PR for this up.

It looks like requests are rate limited at ~1/sec. Requests take roughly anywhere between 400ms to +1s. To address this, requests are now throttled. This may potentially slow down clients who are submitting less than 60 requests, but it gives linear results independent of the number of requests and should be barely noticeable – ymmv. You can grab the latest release here.