n8n-io/n8n

[RabbitMQ Trigger] Not close connection at "Stop Listening"

jmtt89 opened this issue · 5 comments

jmtt89 commented

Bug Description

On Rabbit Management UI i see creating a new connection every time i click the "Test Step" and it does not close when click "Stop Listening"

To Reproduce

  1. Create Trigger RabbitMQ
  2. Create Queue on RabbitManagement (All Defaults)
  3. Click on "Test Step"
  4. Click on "Stop Listening"
  5. Click on "Test Step" again
  6. Check the total number of connections (2)

Expected behavior

close connection with rabbit every time i stop listening.

Operating System

Kubernetes

n8n Version

image docker.n8n.io/n8nio/n8n

Node.js Version

image docker.n8n.io/n8nio/n8n

Database

PostgreSQL

Execution mode

main (default)

Joffcom commented

Hey @jmtt89,

Thanks for the report, I have managed to reproduce this and have created NODE-1306 as the internal ticket to fix it.

luizeof commented

Hi @Joffcom , how are you?

Could you tell me if this issue is related to the fact that RabbitMQ Trigger no longer fetches items from the queue with the execute button?

When in production, it works normally.

But when pressing the execute button to test, the rabbit trigger node stays in an infinite loop and does not continue the workflow.

I have noticed this from version 0.36 onwards.

jmtt89 commented

Hi, I think it is because every time you click "test" you open a new connection, in Rabbitmq the messages are not delivered repeatedly to all conections, they are only delivered to one of them (not necessary the last created)

luizeof commented

Hi, I think it is because every time you click "test" you open a new connection, in Rabbitmq the messages are not delivered repeatedly to all conections, they are only delivered to one of them (not necessary the last created)

Thank you very much, so I believe it is related.

Joffcom commented

Yeah it could be related, the node really needs some updating.