8bit Hex value 01 repeated x 11468800 bytes file crashes Explorer when hashing it

Question

8bit Hex value 01 repeated x 11468800 bytes file crashes Explorer when hashing it

ThePicMan opened this issue 2 years ago · 5 comments

ThePicMan commented 2 years ago

Hello,
windows Explorer crashes if I try to Hash a 11468800 bytes file where each, all and every byte is hex "01".

Answer 1 · 2023-06-17T12:23:43.000Z

This happens with OpenHashTab v3.0.2

I compressed (that was easy) and updated the file here:
!!!!!This crashes Explorer when Hashing it.ZIP

Answer 2 · 2023-06-17T12:25:04.000Z

Stack overflow in sumfile matching regex, probably too many captures. Not exploitable, will try to replace it with a regex that doesn't do that.

Answer 3 · 2023-06-17T12:30:51.000Z

Thank you, keep the great work, I appreciate it, it's a very handy tool.

Answer 4 · 2023-06-28T16:37:34.000Z

So the problem here is the SFV file matcher: SFV files are pretty bad because the file name (which may contain spaces) comes first, followed by whitespace, then the hash. this means that it can only be matched with greedy matchers, since we never know which space is the one we're looking for. I don't think I can solve this in regex, so it seems like I'll have to process these in code instead.

Answer 5 · 2023-06-28T16:53:05.000Z

I decided to just not support spaces in SFV files. They're used primarily in scene releases, and those don't have spaces. The format just sucks, really.