Typescript support motifySvg

[XantreDev]

Is there an existing issue for this?

• I have searched the existing issues

Current Behavior

Wrong typings. You can pass functions and other props to animate prop. And cannot pass regular svg props

Expected Behavior

You can pass regular svg element props. In animate prop there are no functions

Steps To Reproduce

Just use motifySvg for any of components

Versions

- Moti: 0.23.3

Screenshots


Reproduction

I can try to fix it by myself

[XantreDev]

patch that fixes it

diff --git a/node_modules/moti/build/svg/motify-svg.d.ts b/node_modules/moti/build/svg/motify-svg.d.ts
index e079a49..1b8c36e 100644
--- a/node_modules/moti/build/svg/motify-svg.d.ts
+++ b/node_modules/moti/build/svg/motify-svg.d.ts
@@ -1,7 +1,6 @@
 import React from 'react';
 import { ExcludeFunctionKeys, MotiProps } from '../core/types';
 declare type AdditionalProps = {
-    children?: React.ReactNode;
     /**
      * Animated props are not allowed with a Moti SVG component, since they will be overridden.
      *
@@ -23,5 +22,5 @@ declare type AdditionalProps = {
      */
     animatedProps?: never;
 };
-export declare function motifySvg<Props, C extends React.ComponentClass<any> = React.ComponentClass<Props>, Animate = ExcludeFunctionKeys<Omit<React.ComponentPropsWithoutRef<C>, 'children'>>>(ComponentWithoutAnimation: C): () => React.ForwardRefExoticComponent<React.PropsWithoutRef<Props & MotiProps<Animate, import("../core/types").StyleValueWithReplacedTransforms<Animate>, Partial<import("../core/types").StyleValueWithSequenceArraysWithoutTransform<import("../core/types").StyleValueWithReplacedTransforms<Animate>, "transform" | "scaleX" | "scaleY" | "translateX" | "translateY" | "perspective" | "rotate" | "rotateX" | "rotateY" | "rotateZ" | "scale" | "skewX" | "skewY" | Exclude<keyof Animate, "scaleX" | "scaleY" | "translateX" | "translateY" | "perspective" | "rotate" | "rotateX" | "rotateY" | "rotateZ" | "scale" | "skewX" | "skewY">, "scaleX" | "scaleY" | "translateX" | "translateY" | "perspective" | "rotate" | "rotateX" | "rotateY" | "rotateZ" | "scale" | "skewX" | "skewY" | Exclude<Exclude<keyof Animate, "scaleX" | "scaleY" | "translateX" | "translateY" | "perspective" | "rotate" | "rotateX" | "rotateY" | "rotateZ" | "scale" | "skewX" | "skewY">, "transform">> & import("../core/types").StyleValueWithSequenceArraysWithTransform>> & AdditionalProps> & React.RefAttributes<React.RefAttributes<React.ElementRef<C>>>>;
+export declare function motifySvg<C extends React.ComponentClass<any>,Props = React.ComponentPropsWithoutRef<C>,Animate = ExcludeFunctionKeys<Omit<Props, 'children'>>>(ComponentWithoutAnimation: C): () => React.ForwardRefExoticComponent<React.PropsWithoutRef<Props & MotiProps<Animate, import("../core/types").StyleValueWithReplacedTransforms<Animate>, Partial<import("../core/types").StyleValueWithSequenceArraysWithoutTransform<import("../core/types").StyleValueWithReplacedTransforms<Animate>, "transform" | "scaleX" | "scaleY" | "translateX" | "translateY" | "perspective" | "rotate" | "rotateX" | "rotateY" | "rotateZ" | "scale" | "skewX" | "skewY" | Exclude<keyof Animate, "scaleX" | "scaleY" | "translateX" | "translateY" | "perspective" | "rotate" | "rotateX" | "rotateY" | "rotateZ" | "scale" | "skewX" | "skewY">, "scaleX" | "scaleY" | "translateX" | "translateY" | "perspective" | "rotate" | "rotateX" | "rotateY" | "rotateZ" | "scale" | "skewX" | "skewY" | Exclude<Exclude<keyof Animate, "scaleX" | "scaleY" | "translateX" | "translateY" | "perspective" | "rotate" | "rotateX" | "rotateY" | "rotateZ" | "scale" | "skewX" | "skewY">, "transform">> & import("../core/types").StyleValueWithSequenceArraysWithTransform>> & AdditionalProps> & React.RefAttributes<React.RefAttributes<React.ElementRef<C>>>>;
 export {};

[nandorojo]

can you try upgrading moti?

[XantreDev]

I think yes. Project is not working on windows, btw

[XantreDev]

You checked PR? #265

[nandorojo]

can you try upgrading moti?

yarn add moti

[XantreDev]

Your function is shitty typed, still. Why are you ignoring me?

[nandorojo]

I'm responding within minutes, telling you to upgrade to the latest version (0.23.4) where this issue should be resolved. That's hardly ignoring you.

It's possible this works in the example app but not when exported.

[nandorojo]

Try 0.23.5

[nandorojo]

I just created a fresh project with 0.23.4, and it worked fine. Rather than assuming I was ignoring you, it would have been best to just try the upgrade. Locking this.

[XantreDev]

I was looking for changes in the moti master branch. I've seen wrong typings before you hadn't merge my PR))