nandorojo/moti

Skeleton covers children when show={false} on web

adamhari opened this issue · 4 comments

adamhari commented

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Skeleton is rendering overtop of it's children, regardless of the value of the show prop.

Expected Behavior

Skeleton is not visible and it's children are visible when show is false.

Steps To Reproduce

  1. Add a Skeleton component with show=false.
  2. Add children to the Skeleton

Versions

- Moti: 0.24
- Reanimated: 3.0.0
- React Native Web: 0.18.12

Screenshots

Moti 0.23.7

image

Moti 0.24.0

image

Reproduction

https://stackblitz.com/edit/nextjs-dhaw4c?file=pages%2Findex.tsx,package.json

nandorojo commented

Looks like a regression, I’ll look into this tomorrow

  • ❤️1
nandorojo commented

does passing backgroundColor=“transparent” fix it?

adamhari commented

does passing backgroundColor=“transparent” fix it?

Yeah, that seems to fix the issue.

nandorojo commented

Fixed in 0.24.1

  • 🎉1