region in config should be separate between img and the created instances

Question

unusualevent opened this issue 2 years ago · 6 comments

the region for uploading an image in the config for vultr is ewr1, but the closest "region" for creating an instance is "ewr".

the keys between the image upload and the instance creation should be distinct.

currently I have to set the region in the CLI option (for the instance region) to overwrite the config.json (which holds the image region).

Answer 1 · 2023-05-11T00:37:09.000Z

regions and zones are a bit conflated in various providers (iirc mainly because of aws volumes) - so we basically force labeling zones everywhere and then infer regions from that (see https://github.com/nanovms/ops/blob/master/provider/aws/aws.go#L41 )

I think keeping with this behavior vultr would want the same functionality if it isn't using it

Answer 2 · 2023-05-11T00:43:27.000Z

fair - is it possible to update your documentation to clarify that?

e.g. changing the docs:

that the region/zone in the CLI overrides the one in the file
that you should set the region/zone of the image in the config.json, and specify the region of the instance in the cli args?

vs changing the code:

rename Region/Zone to ImageRegion/ImageZone and InstanceZone/RegionZone keys in the config.json

Answer 3 · 2023-05-11T00:52:15.000Z

we definitely can - any prs to https://github.com/nanovms/ops-documentation once approved go live instantly

Answer 4 · 2023-05-11T00:53:17.000Z

oh I'm definitely not a wordsmith.

Answer 5 · 2023-05-25T23:58:35.000Z

w/ #1473 you can use 'ewr1' for both - this follows the convention we're using for other providers

Answer 6 · 2023-05-26T00:51:10.000Z

then the docs should be updated to change it from "ewr" to "ewr1"