naoina/toml

No documentation on the PEG implementation used

guillemj opened this issue · 4 comments

guillemj commented

Please document that the PEG source requires the https://github.com/pointlander/peg project to build. I had to dig through git history to see that this was the project from an old .travis.yml entry. :)

aviau commented

Would #30 be a duplicate?

Guillem, did you manage to generate a working parse.peg.go file using pointlander/peg?

guillemj commented

Alexandre, yeah seems like a dupe. I had not tested because I didn't have those dependencies packaged yet, now that you have done so I've tried. and checking the newly generated output, there's only a couple of changes needed in error.go. I'm posting a pull request to fix that.

aviau commented

I'm posting a pull request to fix that.

Thank you for the effort! :)

guillemj commented

Ok, please see the above pull, please let me know if something seems wrong, or if it does not work for you. Thanks!