napalm-automation/napalm-ansible

-u argument to ansible-playbook is not properly handled

ktbyers opened this issue · 2 comments

Fix looks to be:

$ git diff ./napalm.py
diff --git a/napalm_ansible/plugins/action/napalm.py b/napalm_ansible/plugins/action/napalm.py
index ac37522..bbd70e0 100644
--- a/napalm_ansible/plugins/action/napalm.py
+++ b/napalm_ansible/plugins/action/napalm.py
@@ -13,7 +13,7 @@ class ActionModule(_ActionModule):
             provider = self._task.args.get('provider', {})
 
             provider['hostname'] = provider.get('hostname', provider.get('host', pc.remote_addr))
-            provider['username'] = provider.get('username', pc.connection_user)
+            provider['username'] = provider.get('username', pc.remote_user)
             provider['password'] = provider.get('password', pc.password)
             # Timeout can't be passed via command-line as Ansible defaults to a 10 second timeout
             provider['timeout'] = provider.get('timeout', 60)

Tested in Ansible 2.9rc3.

Haven't regression tested in other Ansible versions

Fixed in #162