nardew/talipp

Inconsistent naming of parameters period_fast/fast_period and period_slow/slow_period in ChainkinOsc

femtotrader opened this issue · 4 comments

femtotrader commented

Hi,

I noticed

talipp/talipp/indicators/ChaikinOsc.py

Lines 19 to 20 in b6369e8

self.period_fast = period_fast
self.period_slow = period_slow

period_fast and period_slow is an inconsistent naming.

See
https://github.com/search?q=repo%3Anardew%2Ftalipp%20fast_period&type=code

it should probably be named fast_period and slow_period to be consistent with others indicators.

Kind regards

nardew commented

Hi @femtotrader , thanks for the feedback. You are right that parameter names are not consistent across all indicators. However, aligning them is a breaking change and no major release is planned at this moment (basically I do not have enough new features to bundle). I will consider for version 2.x.

  • 👍1
femtotrader commented

Thanks @nardew for #95

nardew commented

@femtotrader Glad to help and thanks for the issues you have opened. I am happy to add additional features into the library if there is a proper use case for them (and size of scope). I am especially willing to implement features requested by open source projects leveraging talipp. Feel free to open issues in the future if needed. I cannot promise all of them will be implemented but I will try to prioritize the most burning ones.

  • 👍1