Align all software bus message definitions
jphickey opened this issue · 1 comments
Is your feature request related to a problem? Please describe.
As an extension to the changes in issue #666/pull #678, the same paradigm should be applied to all other message definitions. This is currently only working "by chance" in that the payloads already contain a uint32 (or larger) value so it is already aligned.
Describe the solution you'd like
Change the header structure which is currently defined as a uint8 [] array into either CFE_SB_CmdHdr_t or CFE_SB_TlmHdr_t so it will be correctly aligned.
Additional context
It is safe to assume all remaining message types were already 32-bit aligned because there were no remaining compiler warnings about this, which means this change by itself will not have any effect on the existing message sizes or alignment.
However, when moving to a 64-bit build it may become necessary to enforce 64-bit alignment rather than 32-bit alignment for CFE_SB_Msg_t and in that case, the sizes and padding may change from what it currently is.
Requester Info
Joseph Hickey, Vantage Systems, Inc.