nasa/fprime-tools

Missions's `config_directory` in `settings.ini` is not taken into account

ThibFrgsGmz opened this issue · 1 comments

F´ Version v3.1.0
Affected Component settings.py

Problem Description

A user's project cannot have its own parameter sets. The user may set the value config_directory to his configuration folder, but the tool still points to the configuration folder of F'.

Unless I'm mistaken, the only way to play with these parameters is to directly modify in the configuration of F' existing as a sub-module of the user's project.

Given the fprime-sphinx settings.ini, this feature was available before:

config_directory: Cfg

How to Reproduce

  1. In the project settings.ini file, set a random value to config_directory, like "azerty".
  2. Run fprime-util generate.
  3. Look at the command log:
-- Autocoder constants file: /home/fprime-poc/App/config/AcConstants.ini
-- Configuration header directory: /home/fprime-poc/fprime/config
-- [python3] python3 found at: /home/fprime-venv/bin/python3

Expected Behavior

The user's path must be taken into account to obtain a configuration of the parameters different from the default one of the framework.

By browsing a bit the code base, I think the issue is around these lines.

https://github.com/fprime-community/fprime-tools/blob/2ba8103175423f1de26dacb3e2508207027a516b/src/fprime/fbuild/settings.py#L64

Closing, I was actually using v3.1.0 and this was fixed in v3.1.1 with commit 2ba8103.