Sanitizer Disable Does Not Work
Opened this issue · 2 comments
LeStarch commented
F´ Version | |
Affected Component |
Problem Description
Generating with -DENABLE_SANITIZER_ADDRESS=OFF
does not work. Only the --disable-sanitizer
to disable everything. The culprit is:
Notice how the sanitizers are forced-on.
The fix is in several stages:
- In CMake default to sanitizers should be ==
BUILD_TESTING
(default "ON" when testing). - Above code should read "if disable" set the ENABLES "OFF"
- Take no action on disable sanitizers not set
This way the sanitizers are explicitly turned off, or left to defaults.
thomas-bc commented
Could it also work if in the 4 lines you linked, each value in the cmake_args
dictionary would be set to ON only if they are not in the cmake_args
dictionary already (so not passed in by the user)?
LeStarch commented
That could work too.