Possibility to change cave generation in CGTT versions
SeaGlowingPro opened this issue · 78 comments
Me and "Vector Graphics" found the method for cave generation in the CGTT versions. Notch explained the cave generation, however we might not fully understand it. But, the generation is actually replicated in one of Vector Graphics's games.
Video link: https://www.youtube.com/watch?v=qvuROTCOKlg
IRC Logs:
[20:01:10] <Notch> i place a number of random blocks, then I iterate MAAANY times, picking random tiles. If the tile is immediately next to another tile, I make the new tile a copy of that first tile
[20:01:13] <Notch> *block
How to replicate the generation:
- Go to https://orteil.dashnet.org/experiments/life
- Set the rules to: B5678S45678
- Look at the output image
what's wrong with the current cave gen though? its like, amazing
Note: It isn't exactly this. The site provided applies each iterstion all at once to the entire grid, whiel Notch simply picked blocks at random to modify individually. If the block is more than 50% surrounded by stone/grass, it becomes stone/grass, if it's less than 50%, it becomes air, and if it is 50%, it stays the same. Mess with the parameters (# of iterations) until it matches the CGTT video i guess.
There's nothing wrong with the generation, however, we found the actual method of cave generation used in the real version.
I said less than 50% becomes grass, I meant air, whoops.
note: 256x256x64 = 4194304, so 4194304 random blocks iterated is the rough equivalent of one iteration on Prteil's site (that is if CGTT uses the full height limit anyway, which I don't think it does). And just in case you need to know, we're checking a 3x3x3 cube, not a square.
bruhhhhhh
plx add this lol
didnt we already do this
Re-opened after a long while. The cave generation has been re-coded and backported to one of the CGTT versions (specifically pc-131655)
Note: Takes around 20 seconds to generate a map, which is exactly what Notch experienced in the original version.
Is this final, or are we keeping the original remake? (the one with backported 11a cave generation code)
i need to test it, i will later
uh im not sure, the generation looks much more blocky than the image and the current recreation
on top of that instead of the chunks generating slowly my game lag spikes until theyre all generated
maybe we stick with the old one
You could add, there would be more nostalgia for the old minecraft. Please add these caves.
i believe the current 131648 and 131655 are visually more accurate to the video
I dont know, I do not know much about them. okay
https://www.youtube.com/watch?v=9aHSjwBQLkk
I reduced the generation of caves and teleportation around the world in height, because I was lagging in those moments.
It looks a bit like a orig CG in 360p.
if I fix it up a little, maybe I'll send it here, or to someone
Just... lower the number of iterations from 50 million to something like 25 million and see how it works out
i broke intellij idea
he's not working
Wow this looks pretty accurate. It is messy like it's should be
So, the current rd-131655 remake is kinda accurate with the world size. From what's is shown in the screenshot SeaGlowingPro posted a week ago, I can say it looks really accurate to me. More accurate than the current remake
It's just a matter of thinking about whether this remake will be added or not, because if you look at the remake more precisely at the moment, then these are just expanded caves from c0.0.11a (or c0.0.3a), and if you don't really look into the caves, it will look like the original. The future remake will be much more accurate and nostalgic for CGTT. It is better to choose the second option here.
I really would go for the new remake because It uses the method notch described.
lol I also wanted to do it, but you beat me to it.
Also a Idea would be a test repo or sth like this with multiple testers who than give feedback if the new remake is perfect or if it's not what to improve..
I just came up with an simular idea: Couldn't we could just keep both? The 11a-cave gen and the remake from Vector-Graphics and SeaGlowingPro? And if you want the cave gen like notch described it, play the one from Vector-Graphics and SeaGlowingPro. If the 11a gen looks more accurate to you you can use that
you can always revert the repo back in time
also i have decided and my decision is to keep the new one but improve it slightly because it lag spikes on start and is annoying
and i decided that this repo wont cover any builds before 131655 because they are based on speculations from parties that statements collapse each other and id like to avoid confusion
im going to update pre-classic branch later.
testing.zip
for whoever wants to test, heres the 131655 SeaGlowingPro has prepared us.
It's not giving me lag spikes. It just opens a black window and then after 20 seconds it puts me into the world then the chunks start loading. Everything preformance-related looks fine on my end
yep same, very good
and it does not look like 11a caves at all. Just random blocks that get removed from the world and from caves. it really looks like cgtt to me
let's try to get the seed from the cave game tech test video :tf:
I moved the cave generation to pc-131648
just move rubydung and level classes in 1648
I'm thinking now how to add generation in the build to pc-131655
on all builds except pc-131951 and pc-131151, you need to drag the level class.
on this version bug with grass layers
just look
I do not know what to do here.
on this version bug with grass layers just look
I think it's because it's not made for working in the pc-131648 remake
It could be anything
maybe we will stay on the old versions of pc-131951 and 131151
the speculations are no longer supported
The new remake looks good in my opinion
I agree with you.
All that remains is to find the world on which Notch played.
This was a joke 💀 We cannot find notch's world. The chance to do so is like 1/4,000,000,000
I know the chances are pretty slim here.
also currently, there's no saving :(
Hope we get a saving mod or sth like this soon
nasko222 prays for him to add this
we already had a hard time forcing him to change the pre-classic branch
more precisely, he thought of it himself
I wonder were the minecraft wiki gets the info from, that saving was added in pc-132011. The only reference linked is the rd-132211.json
maybe they just didn't know about the builds before rd-132211, and then they would have created a separate page with the development of rd-132211
nothing is written about saving, maybe saving was actually added only in 2211?
I have read everything that is closer to this time, there is not a single word about saving
most likely he forgot to write about it
Yeah. It could've been around pc-132011 but it also could've been added on May 12th as well
I think making a saving mode for it is pretty simple. Just add the saving method (and also the loading method) from pc-132011 to the level.class in the pc-131655 remake and call it in the main class like pc-132211 does.
I'm going to test it now
I know for a fact that the code of notch remake had saving
lol Maybe they know the story better than we do.
But please don't use the code of notch remake. the generation just sucks
there you need to copy one line that allows you to save the world in the level.dat file
I forgot that I won't be able to work with versions right now, because my program gives an error when starting the game.
Only SeaGlowingPro can make a saving mod rn iirc
I'm going to try to do something with pc-131151 now, because I don't like
it later I'll do pc-131951
lol
I'm tired of it somehow, I'll continue a little later, it really pisses me off that all my attempts to do this stuff don't work
Because you don't have the source code
on this version bug with grass layers
just look
is this in the new testing version that i sent above?
I want to transfer the generation to pc-131151
but there is another problem
this one
theres no such thing as 131151 here, i am asking if the version i sent above in "testing.zip" caused the grass bug from your image
No, because I was showing a picture of a different version.
ok but please clarify that because you posted this after my testing zip so it could cause confusion
I signed on top that I am working on builds up to pc-131655
i create this but sky is black
anyway in conclusion the new build is done, preclassic will be updated later thanks SGP and Vector
theres no such thing as 131151 here, i am asking if the version i sent above in "testing.zip" caused the grass bug from your image
He is messing around with the code
trying to do saving and porting the generation to speculation
but yk what happens when you try editing compiled code XD