natefaubion/purescript-routing-duplex

Failed pattern match for invalid URL encoded path

dederer opened this issue · 1 comments

dederer commented

In production, I got a runtime error in the parsePath function from the Routing.Duplex.Parser module:

stack: Error: Failed pattern match at Data.Maybe (line 281, column 1 - line 281, column 46): Nothing

The reason for the error is an invalid URL encoded string "%D0%BF%D0".

For example, this command results in an error:

parsePath "https://example.com?keyword=%D0%BF%D0"
natefaubion commented

Yeah, we need to remove the unsafe usage here:

purescript-routing-duplex/src/Routing/Duplex/Parser.purs

Line 166 in f4430e6

unsafeDecodeURIComponent = unsafePartial fromJust <<< decodeURIComponent

  • 👍1