nathangiusti/PySense

Correction on PySenseDashboard.Dashboard.add_share function

Closed this issue · 2 comments

bryan-dagasdas commented

Line 138 of https://github.com/nathangiusti/PySense/blob/master/PySense/PySenseDashboard.py should be changed
from

if 'shareId' == curr_share['shareId']:

to

if share_id == curr_share['shareId']:

The current code is not able to remove duplicate share_id's in the shareTo field.

nathangiusti commented

@bryan-dagasdas v1.0.4 is on pypi with the fixed code.

Cheers,

Nathan

bryan-dagasdas commented

Thanks! Good job on creating this library. It is a big help!

  • 👍1