directory patterns permit children when they should be ignored
softprops opened this issue · 2 comments
The following path should be ignored as a child of foo/bar but it's currently allowed. The following yields false being the baz.rs file would not be ignored
let gip = Pattern::new("foo/bar", Path::new("/")).unwrap();
println!("{}", gip.is_excluded(Path::new("foo/bar/baz.rs"), false))
@softprops I'm so sorry, I don't know how I missed the notification for this when you first raised it! I will try to have a look into this as soon as possible for you. 👍
HI @softprops — thanks for your issue and sorry for never coming back here! Life rather got in the way, to say the least.
After much consideration I've decided I'm going to archive this crate, about which you can read more here:
https://github.com/nathankleyn/gitignore.rs#project-status
It's a tough decision to make but I want to be realistic that the crate isn't in a good state — it needs a total overhaul to fix the kinds of issues that are being reported, but I haven't the time to commit to it. I can't reasonably handover what is here to a new maintainer, so instead I have made some recommendations in the README for crates you should consider using instead for ignoring files. Please let me know if you need assistance with migrating should you be using this crate.