bind print-level and print-depth to nil when saving the environment instead of using print-dup

Question

bind print-level and print-depth to nil when saving the environment instead of using print-dup

hiredman opened this issue 10 years ago · 2 comments

https://github.com/nathanmarz/cascalog/blob/develop/cascalog-core/src/clj/cascalog/logic/fn.clj#L13-L14

the # you are trying to avoid using print-dup are inserted because you have print-level and print-depth bound at the repl, if you bind those to nil you don't need print-dup, and print-dup should be avoided because it is not portable (it creates strings which to read properly depend on eval reader)

Answer 1 · 2015-01-29T15:00:55.000Z

@hiredman but don't we always have the eval reader, when deserializing these functions?

Answer 2 · 2015-04-19T06:10:34.000Z

@hiredman, happy to re-open this and make that change - closing for now since I don't know of a case where we won't have the eval reader. Good to know, btw.