Problem with rejecting publish requests - "Go to node" is set on all requests
Opened this issue · 16 comments
Hi,
We've been using Plumber in a project, where the users frequently submit new pages to be approved and published. However, there seems to be an issue, which might be a bug in the library.
When the acceptor enters '[vertical menu on the left]Content->[header]Content->[tab]Workflow' they can see "Tasks requiring my approval" section on top.
There can be many publish requests for new pages (of some specific type), but once the approver clicks the green dropdown in the "Actions" column and chooses "Reject changes" option, all of the dropdowns (i.e. even those not related to the specific publish request we wish to reject) start to display "Go to node" option - we can no longer approve any other publish request from this view; we can however do this by clicking "Go to node" button and then "Approve changes" in the bottom right corner.
Could you please have a look into this?
Regards,
Marek
Hi @mtywoniak I've fixed this in the next patch release - there was some funky stuff going on with reordering buttons when a task is rejected, which was affecting all tasks in the table rather than just the rejected one.
Updating will required Umbraco v7.15.5, due to some other changes in the release.
Build is available here => https://ci.appveyor.com/project/nathanwoulfe/umbracoworkflow/builds/34176253/artifacts if you need it urgently, otherwise will be on NuGet when I release.
Hi @nathanwoulfe
Thanks for your reply and making this release available for me so quickly.
I've also got a question - when do you think you will be releasing this package? Do you think this will be like days, weeks or rather months? It would be great if this would also be available as a NuGet, so we can keep track of package updates there, in our project.
Regards,
Marek
It's on NuGet now 😄
@nathanwoulfe
I've tried to use the new version of Plumber and the issue with "Go to node" is gone :)
However, now there's a new problem: when we reject a publish request, the button goes back to "Approve" state (should be "Rejected" or something similar). When I click this "Approve" button on a request which I know I have already rejected, there's an error section coming up from the right side of the layout that informs me about InvaildOperationException (please refer to the screenshot attached).
Could you please take a look?
Ah, so it does. That explains why the buttons were handled the old way - I'll review.
Should be ok now - I haven't published to NuGet, would appreciate if you could verify the fix first. Can grab the package zip from https://ci.appveyor.com/project/nathanwoulfe/umbracoworkflow/build/artifacts and replace the JS files in your site.
Thanks for this, I'll check now, run some tests and come back to you.
@nathanwoulfe I've walked through some workflow paths and the labels seem to be okay now. Also, the error with InvalidOperationException has disappeard- which is very good, thanks!
I've observed one thing though: when I enter the "Workflow" section from the left panel menu, I can see following error:
Could you please try to reproduce it? This might be something Umbraco core-related, but I've not observed it until now.
And the last thing: is there any way to show more than 5 publish requests in awaiting approval tasks ToC? Sometimes we have a great deal of publish requests coming from many users and we would like to see more of them. So far, we can only see top five:
I there any way to see a pagination or even a scroller in this table so that we can load more requests or go to the next page?
That log error is a pest - it's throwing because there is no log file for the current day. Shouldn't be a big deal to fix.
I thought the dashboard had pagination (might be mixed up with V8). Will see why it's not working and if it's easily fixed
@mtywoniak found the issue - pagination exists for the dashboard, but was referencing the wrong value when setting total pages. Will include this in the next release.
@nathanwoulfe many thanks for your help!
And regarding the pagination fix - when can we expect the next release?
If you can install the beta and verify, I can push it out tomorrow.
Sure, I will install it and let you know asap.
@mtywoniak if you could share the logs too that would be useful for tracking down log dates error - I can't reproduce that locally, even if I delete all log files... It should be written to WorkflowLog.txt
I'll release a patch now though with the pagination update
@nathanwoulfe It turns out that my WorkflowLog.txt is empty. I'll install the version with pagination update and let you know after some tests.
@nathanwoulfe I've installed the newest version and it seems that the errors are gone and the pagination is back in the workflow view. Many thanks for you help.