nats-io/nats.ex

Connection establishing prinout

fallion opened this issue · 3 comments

fallion commented

Hi,

Currently the connection prinout here

nats.ex/lib/gnat/connection_supervisor.ex

Line 60 in f2accd1

Logger.info "connecting to #{inspect connection_config}"
uses Logger.info, this means that if you are deploying this with authentication enabled you will print the secrets into std.out unless you are silencing all info messages.

I have the following proposals:

  • change it to Logger.debug

OR

  • strip any secret data from this printout so that the URL, PORT, AUTH_REQUIRED and any other non-secret info gets printed

Thanks for any other suggestions or help :) We're already using this in production for one of our apps.

mmmries commented

@fallion this is a great point. I'll try to get this patched shortly

fallion commented

I can make the PR if you want. Just curious about which solution you would go for. :)

mmmries commented

I think Logger.debug is the easiest solution and it probably makes sense since you don't need that information in production logs