naver/cover-checker

Report shows 0/0 100% coverage on not empty chanages

ideoma opened this issue · 1 comments

Awesome tool, thanks for open sourcing it!

I had a strange code coverage report here
questdb/questdb#1025

The coverage report file is here
https://dev.azure.com/questdb/questdb/_build/results?buildId=1197&view=artifacts&pathAsName=false&type=publishedArtifacts

and the log is

16:39:14.400 [main] INFO  (CoverChecker.java:47) Check new line of code coverage by JacocoReportParser
16:39:14.409 [main] INFO  (CoverChecker.java:53) read diff by GithubDiffReader
16:39:14.441 [Thread-2] INFO  (GithubDiffManager.java:40) get diff questdb/questdb/1029
16:39:14.706 [Thread-2] INFO  (GithubDiffReader.java:59) get file core/src/main/java/io/questdb/cutlass/line/tcp/LineTcpMeasurementScheduler.java
16:39:14.714 [Thread-2] INFO  (DiffMapper.java:56) parse diff / Optional[core/src/main/java/io/questdb/cutlass/line/tcp/LineTcpMeasurementScheduler.java]
16:39:14.720 [Thread-2] INFO  (GithubDiffReader.java:59) get file core/src/test/java/io/questdb/cutlass/line/tcp/LineTcpConnectionContextTest.java
16:39:14.720 [Thread-2] INFO  (DiffMapper.java:56) parse diff / Optional[core/src/test/java/io/questdb/cutlass/line/tcp/LineTcpConnectionContextTest.java]
16:39:14.721 [Thread-2] INFO  (GithubDiffReader.java:59) get file core/src/test/java/io/questdb/cutlass/line/tcp/LineTcpServerTest.java
16:39:14.723 [Thread-2] INFO  (DiffMapper.java:56) parse diff / Optional[core/src/test/java/io/questdb/cutlass/line/tcp/LineTcpServerTest.java]
16:39:14.750 [main] INFO  (ConsoleReporter.java:28) coverage check result
16:39:14.757 [main] INFO  (ConsoleReporter.java:30) 0/0 100
16:39:17.051 [main] INFO  (CoverChecker.java:61) check result pass

https://dev.azure.com/questdb/questdb/_build/results?buildId=1197&view=logs&j=55742375-e338-54e5-b4e4-08a24a4c7b3d&t=8306d4b1-7a02-5def-a13e-6cf8bb46e3ff

Would be good to find out what this is, maybe a known limitation of some sort.

Hi @ideoma. Thanks for using our tool. And I'm sorry about answer late.
In your case. LineTcpMeasurementScheduler seems removed some code lines only.

Now It is working as we expected. :)

Please, let me know if you get another issue. I will answer ASAP!
Have a nice day.