Error in scene graph pair creation
Closed this issue · 1 comments
vmanzin commented
The MASt3R-SfM paper describes the algorithm for scene graph construction and has the following snippet:
All remaining images are then connected to their closest keyframe
However, the code for graph construction uses argmax() on the distance matrix which returns the most distant keyframe:
mast3r/mast3r/retrieval/graph.py
Line 61 in 1159b91
It's interesting that the output results are still very good even with this way of creating the scene graph, at least on my specific sample of ~80 scenes. Great work!
yocabon commented
Hi, thank you a lot for noticing this error!
It was introduced when we rewrote retrieval/graph from our internal repository to this one.