naver/ngrinder

Github base-url validation is failing for company internal enterprise github address

jordao76 opened this issue · 0 comments

Hello, while configuring a github base-url in the .gitconfig.yml file I'm getting an error from the controller UI:

Field 'base-url' doesn't conform to url format.
Please check your .gitconfig.yml

The config I'm using is for my company's internal enterprise github address, similar to this:

base-url: https://github.mycompany.corp/api/v3

Note that corp is an internal domain for my company, and not a top-level domain (ref: https://data.iana.org/TLD/tlds-alpha-by-domain.txt)

Code where the error happens:

Please check this and perhaps make the validation more lenient. I'm not sure this would help:

https://commons.apache.org/proper/commons-validator/apidocs/org/apache/commons/validator/routines/UrlValidator.html#ALLOW_LOCAL_URLS