navisayslisten/AceEditorVTT

[Request] Compatibility

Closed this issue · 6 comments

ardittristan commented

Please check for compatibility with other modules that use ace (like not enough npcs) since ace is very prone to breaking if multiple modules use it (ace.config.basePath might break other modules using ace for example)

navisayslisten commented

Thanks man. Will do. I'm just seeing if I can standardize importing ace and its dependencies for now. It's very touchy.

navisayslisten commented

My forked repo of yours is looking a lot better than this one. But took me a while to understand what it was your code was editing in the first place. UI dev isn't my area of expertise.

DrMcCoy commented

The Furnace is no more, but this editor module is still incompatible with at least one of the successor modules, Advanced Macros.

And yeah, even if I disable the Furnace checks, the editor breaks with Advanced Macros enabled.

Is there a way to make them compatible?

navisayslisten commented

I'll look into it.

  • 👍1
navisayslisten commented

Please use VTTMacroEditor instead @DrMcCoy . This project will be closed.

  • ❤️1
DrMcCoy commented

Ah.

Thank you for your service!