Occasional fails with circleci
Cadair opened this issue · 6 comments
I have seen errors along these lines a couple of times now:
cistern: Provider circleci-0: monitorPipeline failed with parsing time "" as "2006-01-02T15:04:05Z07:00": cannot parse "" as "2006" (https://circleci.com/gh/sunpy/sunpy/36079?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)
It seems to happen on a newly pushed branch, maybe force pushes? Let me know if there is anything I can do to get more details when it happens.
yeah, after a short while it goes away on the same branch.
Thanks for reporting this. It seems that the Circle CI API sends cistern a build without a creation date and cistern fails because this date is mandatory. I think I have enough information to fix this, I'll let you know when I have a solution.
my best guess at the moment is that it's because the build is still pending, but I am not 100% sure.
Yes, that's probably it. I changed cistern so that the date causing the crash may now be null. The fix is on this branch: https://github.com/nbedos/cistern/tree/bugfix/optional_creation_date
If you're able to reproduce the crash fairly easily I can leave the fix on this branch for now for you to test, if not I can merge it in master. I'm fairly confident in the changes I made so I'm OK with merging them without further testing.
I tested this out on the azure branch (which seemed to also have these fixes in?) seems to work well.
Thanks for testing this. I just merged my changes in master.