nbesli/pdf-merger-js

Failing test on windows since v5.0.0

Opened this issue · 0 comments

Since the 5.0.0 release the test don't nun anymore on windows:

(node:12860) ExperimentalWarning: VM Modules is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)

FAIL test/fixtures.test.js
  ● PDFMerger › merge two simple files

    Path contains invalid characters: \C:\Users\xxxxxxxx\pdf-merger-js\test\tmp

      15 | describe('PDFMerger', () => {
      16 |   beforeAll(async () => {
    > 17 |     await fs.ensureDir(TMP_DIR)
         |              ^
      18 |   })
      19 |
      20 |   test('merge two simple files', async () => {

      at checkPath (node_modules/fs-extra/lib/mkdirs/utils.js:16:21)
      at Object.<anonymous>.module.exports.makeDir (node_modules/fs-extra/lib/mkdirs/make-dir.js:12:3)
      at Object.defineProperty.value (node_modules/universalify/index.js:21:45)
      at Object.ensureDir (test/fixtures.test.js:17:14)

I see two problems here:

  1. The VM Modules is an experimental feature warning comes from the --experimental-vm-modules parameter, that is needed to support ESM modules in jest, wich is still experimental: https://jestjs.io/docs/ecmascript-modules
  2. The invalid path is propably caused by the \C:.