body-soft-max-line-length exception

Question

body-soft-max-line-length exception

knocte opened this issue a year ago · 2 comments

This rule should not break the build if the offending line exceeds 64 chars because it uses a commit hash at the end.

Testcase:

GrpcService: fix some logging nits

These mistakes were made in 45faeca2f0e7c9c5545f54fb3fcc815f52b8a7cf.

Testcase that should still break the build (because line is longer than 64 chars before the commit hash):

GrpcService: fix some logging nits

These mistakes were made in this GrpcService's RunIntoMeService commit: 45faeca2f0e7c9c5545f54fb3fcc815f52b8a7cf.

Answer 1 · 2023-07-17T07:21:00.000Z

@webwarrior-ws please work on this issue if you are taskless.

Answer 2 · 2023-08-01T08:42:41.000Z

@realmarv I think @webwarrior-ws got stuck with this task, I don't remember his reasoning. Please pair with him on it after he's done with his NLitecoin low-prio task.