nbusseneau/hephaistos

MacOS: Failed to apply 'viewport' patch

Closed this issue · 5 comments

Unfortunately, hephaistos fails to apply the patch on my Macbook.

I moved hephaistos to /Users/marcel/Library/Application Support/Steam/steamapps/common/Hades:

~/Library/Application Support/Steam/steamapps/common/Hades
❯ ll
total 6.9M
drwxr-xr-x 3 marcel staff   96 Apr  7 21:18 Game.macOS.app
drwxr-xr-x 4 marcel staff  128 Apr  8 18:55 hephaistos-data
-rwxr-xr-x 1 marcel staff 6.9M Feb 28 16:29 hephaistos

I executed the patching process in this directory using ./hephaistos.

The log I get from the Terminal:

Hi! This interactive wizard will help you to set up Hephaistos.
Note: while Hephaistos can be used in interactive mode for basic usage, you will need to switch to non-interactive mode for any advanced usage. See the README for more details.

Current version: v1.6.3
Latest version: could not check latest version -- perhaps no Internet connection is available?

Pick an option:
1. Patch Hades using Hephaistos
2. Restore Hades to its pre-Hephaistos state
3. Check current Hades / Hephaistos status
4. Exit
Choice: 1

Pick an option:
1. Select from common 21:9 resolutions
2. Select from common 32:9 resolutions
3. Select from common 48:9 / triple screen resolutions
4. Input resolution manually
5. Cancel
Choice: 2

Select resolution:
1. 3840 x 1080
2. 5120 x 1440
3. Cancel
Choice: 2

Select HUD preference (for 32:9, try out both options and see what you prefer!):
1. Expand HUD horizontally (recommended for 21:9)
2. Keep HUD in the center (recommended for 48:9 / triple screen)
3. Cancel
Choice: 2

INFO:hephaistos:Using resolution: (5120, 1440)
INFO:hephaistos:Using '--scaling=hor+': computed patch viewport (3840, 1080)
INFO:hephaistos:Using '--hud=center': HUD will be kept in the center of the screen
ERROR:hephaistos:Failed to apply 'viewport' patch in 'Game.macOS.app/Contents/MacOS/Game.macOS' (no occurrences found)

I checked the printed directory Game.macOS.app/Contents/MacOS/Game.macOS and the Game.macOS file is present.

Hey, thanks for the report. Probably the MacOS binary structure has changed since the last time I had a look at it, and so the hex patches need to be updated. I will try to have a look this weekend.

Do you have a Discord handle I could add you at? That would speed up the testing :)

Added! Feel free to remove your comment if you don't want to keep it advertised here :)

This should be fixed by eb6e687, test build here: hephaistos-macos.zip

Released in v1.6.4.