nci/mosrs-setup

Detect more username inconsistencies

Closed this issue · 1 comments

penguian commented

In mosrs.auth.update, in the code after

# Clear the user and try one more time

the code

        username, passwd = request_credentials(username)
        save_rose_username(username)
        if not svn_username_is_saved(username):
            save_svn_username(username, SVN_URL)

should be

    # Ask for credentials
    username, passwd = request_credentials(username)
    # Check the realmstring and username stored by Subversion
    if not check_saved_svn_username(username):
        raise
    # Save credentials
    save_rose_username(username)

matching the code earlier in the function, to ensure that the saved username is consistent between .subversion/auth/* and .subversion/servers.