ncuillery/rn-diff

RN 0.34 AppManifest.xml is missing `android:name` attribute in `application` tag

rigdern opened this issue · 2 comments

rigdern commented
  • FB's template for AndroidManifest.xml for RN 0.34 has an android:name attribute.
  • In rn-diff's app for RN 0.34, AndroidManifest.xml is missing the android:name attribute in its application tag.
ncuillery commented

You're right, there was an issue with the former Yeoman generator used by the react-native upgrade command: only files located in android and android/app directories were upgraded.
See this block.

The AndroidManifest.xml is located in a sub-directory android/app/src/main that wasn't selected by the glob pattern.

It means that the AndroidManifest.xml of the RnDiffApp hasn't been upgraded since the init of the app (with RN 0.23.0). That explains the difference.

Two other files are concerned as well:

  • android/keystores/BUCK
  • android/keystores/debug.keystore.properties

Fortunately, the RN team replaced the Yeoman generator by a home-made solution in RN 0.39.0 which upgrades these files correctly.

Note that the compare view from 0.38.0 to 0.39.0 is not relevant for the AndroidManifest.xml file. Actually, it shows the diff from 0.23.0 to 0.39.0 (because the RnDiffApp has been generated in 0.23.0).

ncuillery commented

I close this because there's nothing I can do. I have referenced the issue in the README.md#known-issues

  • 👍2