Add Ellipses as valid type for remote execution

Question

Add Ellipses as valid type for remote execution

JadenFiotto-Kaufman opened this issue 7 months ago · 2 comments

JadenFiotto-Kaufman commented 7 months ago

Answer 1 · 2024-05-30T15:11:49.000Z

Hi, I'm working on it and francescortu@77f1005 should work. However since the server doesn't have the EllipsisType, it currently raises an error ( I guess it isn't able to compile the EllipsisType since it doesn't know what is it). Is it reasonable?

Answer 2 · 2024-05-30T23:53:01.000Z

@francescortu Looks perfect! I would use Ellipsis instead of type(...). And yeah NDIF will have to be built with the version of nnsight that includes this change. If you wanted to you could build a dev version of NDIF with the nnsight version pointed at your nnsight version: https://github.com/ndif-team/ndif