ndt-project/ndt

Add java/flash plugin detection to JS UI page

Closed this issue · 14 comments

Original issue 154 created by aaronmbr on 2014-08-01T05:30:47.000Z:

Page should detect if user has installed required plugin and automatically set proper backend for JS UI. Also user should be able to easily switch between flash/java NDT client.

Comment #1 originally posted by aaronmbr on 2014-08-01T05:32:30.000Z:

<empty>

Comment #2 originally posted by aaronmbr on 2014-08-06T05:23:33.000Z:

Changes available on Issue154 branch (r1129). I have added two buttons allowing to set which client should be used as backend (java/flash). By default if java is installed then it is used. Feel free to review.

Comment #3 originally posted by aaronmbr on 2014-08-25T07:05:50.000Z:

Does anyone have some feedback related to these changes? Will be very appreciated :)

Comment #4 originally posted by aaronmbr on 2014-08-25T07:06:54.000Z:

Does anyone have some feedback related to these changes? Will be very appreciated :)

Comment #5 originally posted by aaronmbr on 2014-08-25T17:47:59.000Z:

Hey Sebastian!

We have a whole implementation ready. Sorry that I haven't posted the patch yet. Jordan (from OTI) did a great job on it. I will upload ASAP. Sorry for the delay!

Comment #6 originally posted by aaronmbr on 2014-09-15T09:40:13.000Z:

Hi Will,
what is the status of these changes? Would it be possible to upload them or/and list things that still need to be implemented to release new NDT version?

Comment #7 originally posted by aaronmbr on 2014-10-09T12:07:48.000Z:

I attached patch from Jordan regarding this issue. We should check which version is better and/or merge both solutions to trunk.

Comment #8 originally posted by aaronmbr on 2014-10-09T12:12:12.000Z:

I attached patch from Jordan related to this issue. We should check how we can use it within our solution and merge both patches to trunk.

Short description of the patch:

"This patch adds a customizable feature for dealing with performance-limited flash
runtimes. In a nutshell, the patch allows anyone who hosts an NDT
test to specify (via an HTML parameter) whether performance-limited
flash runtimes should (a) be treated the same as non-limited ones, (b)
only be allowed to run against a "fallback" server, or (c) not allowed
to run the NDT test via flash at all."

Comment #9 originally posted by aaronmbr on 2014-10-09T12:15:13.000Z:

Sebastian, according to your question there is the following answer:

"The only open thing on an NDT release candidate out is getting it so that the Flash clients works out of the box when you do an RPM install (i.e. it’s not a weird arduous process of “edit this file, and that file, and install this, and then edit this file”. You just do a “yum install ndt-server”, start NDT, navigate to the NDT URL and it Just Works (tm))"

Comment #10 originally posted by aaronmbr on 2014-10-27T10:44:19.000Z:

<empty>

Comment #11 originally posted by aaronmbr on 2014-11-03T15:33:13.000Z:

I have applied mentioned patch to Issue154 branch (also I have tested it and fworks OK). Does anyone have any feedback on these or/and my changes related client changing? If not, I will merge these changes into trunk.

Comment #12 originally posted by aaronmbr on 2014-11-03T15:34:48.000Z:

I have applied mentioned patch to Issue154 branch (also I have tested it and works OK). Does anyone have any feedback on these or/and my changes related client changing? If not, I will merge these changes into trunk.

Comment #13 originally posted by aaronmbr on 2014-11-04T14:23:33.000Z:

Both are fine by me

Comment #14 originally posted by aaronmbr on 2014-11-04T15:29:22.000Z:

Thanks for feedback. I have merged these changes into trunk.