Await and check logic of async assertions in tests
Closed this issue · 1 comments
AlanSl commented
This came up in review of #305 (specifically this comment thread)
simoneb yesterday: when you make async assertions (such as .rejects or .resolves), you need to either return or (preferably, in my opinion) await the result of the assertion, otherwise the assertion will be a noop
AlanSl yesterday: ...I've found a few pre-existing examples where I think tests aren't behaving as intended... I might fix these in a small separate PR.
simoneb yesterday: yes please, any async tap assertions need to be awaited for them to have any effect
github-actions commented