nebula-orchestrator/worker

Build breaking due to unavailable package `freeze`

vineyyadav opened this issue · 3 comments

Expected/Wanted Behavior

The build should succeed.

Actual Behavior

The build breaks with error for freeze module dependency which it seems has been deprecated by its owner.

Steps to Reproduce the Problem

Clone the latest code and run docker build command.
Logs:

worker ~$ docket build .
Step 1/7 : FROM python:3.8.3-alpine3.10
3.8.3-alpine3.10: Pulling from library/python
b038bcb63e9c: Pulling fs layer
d00770a9e6c3: Pulling fs layer
b69ac7b1ba1f: Pulling fs layer
bf6a8d0b7294: Pulling fs layer
fc2c76740c89: Pulling fs layer
bf6a8d0b7294: Waiting
fc2c76740c89: Waiting
d00770a9e6c3: Verifying Checksum
d00770a9e6c3: Download complete
bf6a8d0b7294: Download complete
b038bcb63e9c: Verifying Checksum
b038bcb63e9c: Download complete
fc2c76740c89: Verifying Checksum
fc2c76740c89: Download complete
b038bcb63e9c: Pull complete
d00770a9e6c3: Pull complete
b69ac7b1ba1f: Verifying Checksum
b69ac7b1ba1f: Download complete
b69ac7b1ba1f: Pull complete
bf6a8d0b7294: Pull complete
fc2c76740c89: Pull complete
Digest: sha256:152b1952d4b42e360f2efd3037df9b645328c0cc6fbe9c63decbffbff407b96a
Status: Downloaded newer image for python:3.8.3-alpine3.10
 ---> 0f34d7318ab6
Step 2/7 : RUN apk add --no-cache build-base python3-dev linux-headers
 ---> Running in cf383cc6d11d
fetch http://dl-cdn.alpinelinux.org/alpine/v3.10/main/aarch64/APKINDEX.tar.gz
fetch http://dl-cdn.alpinelinux.org/alpine/v3.10/community/aarch64/APKINDEX.tar.gz
(1/23) Upgrading musl (1.1.22-r3 -> 1.1.22-r4)
(2/23) Installing binutils (2.32-r0)
(3/23) Installing libmagic (5.37-r1)
(4/23) Installing file (5.37-r1)
(5/23) Installing gmp (6.1.2-r1)
(6/23) Installing isl (0.18-r0)
(7/23) Installing libgomp (8.3.0-r0)
(8/23) Installing libatomic (8.3.0-r0)
(9/23) Installing libgcc (8.3.0-r0)
(10/23) Installing mpfr3 (3.1.5-r1)
(11/23) Installing mpc1 (1.1.0-r0)
(12/23) Installing libstdc++ (8.3.0-r0)
(13/23) Installing gcc (8.3.0-r0)
(14/23) Installing musl-dev (1.1.22-r4)
(15/23) Installing libc-dev (0.7.1-r0)
(16/23) Installing g++ (8.3.0-r0)
(17/23) Installing make (4.2.1-r2)
(18/23) Installing fortify-headers (1.1-r0)
(19/23) Installing build-base (0.5-r1)
(20/23) Installing linux-headers (4.19.36-r0)
(21/23) Installing pkgconf (1.6.1-r1)
(22/23) Installing python3 (3.7.10-r0)
(23/23) Installing python3-dev (3.7.10-r0)
Executing busybox-1.30.1-r3.trigger
OK: 281 MiB in 56 packages
Removing intermediate container cf383cc6d11d
 ---> 9c8d9ff9dd65
Step 3/7 : COPY . /worker
 ---> b715c0bdd177
Step 4/7 : RUN pip install -r /worker/requirements.txt
 ---> Running in f7879cb69bd5
Collecting backports.ssl-match-hostname==3.7.0.1
  Downloading backports.ssl_match_hostname-3.7.0.1.tar.gz (5.7 kB)
Collecting certifi==2020.12.5
  Downloading certifi-2020.12.5-py2.py3-none-any.whl (147 kB)
Collecting chardet==4.0.0
  Downloading chardet-4.0.0-py2.py3-none-any.whl (178 kB)
Collecting configobj==5.0.6
  Downloading configobj-5.0.6.tar.gz (33 kB)
Collecting croniter==1.0.10
  Downloading croniter-1.0.10-py2.py3-none-any.whl (14 kB)
Collecting dnspython==2.1.0
  Downloading dnspython-2.1.0-py3-none-any.whl (241 kB)
Collecting docker==4.4.4
  Downloading docker-4.4.4-py2.py3-none-any.whl (147 kB)
Collecting docker-pycreds==0.4.0
  Downloading docker_pycreds-0.4.0-py2.py3-none-any.whl (9.0 kB)
Collecting dpath==2.0.1
  Downloading dpath-2.0.1.tar.gz (21 kB)
ERROR: Could not find a version that satisfies the requirement freeze==3.0 (from -r /worker/requirements.txt (line 10)) (from versions: none)
ERROR: No matching distribution found for freeze==3.0 (from -r /worker/requirements.txt (line 10))
WARNING: You are using pip version 20.1.1; however, version 21.0.1 is available.
You should consider upgrading via the '/usr/local/bin/python -m pip install --upgrade pip' command.
The command '/bin/sh -c pip install -r /worker/requirements.txt' returned a non-zero code: 1

Specifications

@naorlivne , I could not find the freeze module being used anywhere in worker code. If not needed, can it be removed?

Alternatively, it should be replaced with the renamed module pretty-dump

Seems like they removed it from Pypi, I'm having a look at where it's being used, most likely it's a dependency of a dependency that has since been removed so will likely be ok to remove but will need to confirm first

Removed it and not seeing any affect so should be good to go, please reopen if your seeing any issues as a result I missed with my tests