nebula-orchestrator/worker

RabbitMQ connections are not closed properly

naorlivne opened this issue · 1 comments

Similar to nebula-orchestrator/manager#16

Expected/Wanted Behavior

RabbitMQ connections should be closed whenever it's usage ends and it's attached channel is closed

Actual Behavior

Channel is closed but the connection is kept until it times out

How to fix

The rabbit_login function should also return the "rabbit_connection" & not just the "rabbit_connection_channel" and whenever the channel is closed explicitly it needs to close the connection as well.

On further inspection connections are closed correctly in the worker.