Broken in React v15.5.0+

[seenickcode]

React doesn't use Prop types anymore by default. Running this example throws an error:
react 'PropTypes' is not defined no-undef

Adding the new prop-types packages still doesn't work:

App.propTypes = {
  mixpanel: PropTypes.string.isRequired,
};

Throws: "TypeError: Cannot read property 'track' of undefined" when using it in your example like this:

this.context.mixpanel.track('myeventname');

It looks like the ugly alternative for now is to just use the mixpanel-browser package. Holy crap, yuck, is there a better way?

import mixpanel from 'mixpanel-browser';

class MyComponent extends Component {

  render() {
      mixpanel.init('mykey');
      if (process.env.NODE_ENV === 'production') {
        mixpanel.track('myevent');
      };
    
      // ...
  }
}

[neciu]

Thanks for that. I'll fix that in a day or so.

[neciu]

PropTypes issue was resolved some time ago with version 0.0.9.

I believe you have a typo:
Instead of:

App.propTypes = {
  mixpanel: PropTypes.string.isRequired,
};

You should have:

App.contextTypes = {
    mixpanel: PropTypes.object.isRequired
};

Here is full example app file: https://github.com/neciu/react-mixpanel/blob/master/examples/simple/src/app.js

More about context you can find here.

I have double checked the example and it works fine. Looking forward for your response.

[seenickcode]

Hey @neciu thanks for the quick reply.

Unfortunately, I get the same error, with your code as well.

Maybe it could be an eslint config issue? I found this article re that https://stackoverflow.com/questions/45692537/proptypes-is-not-defined

[neciu]

Yup it seems to be problem with create-react-app/eslint.

Please provide minimal working example of the error so I can help further!

[seenickcode]

Sure! ``` create-react-app test cd test yarn install yarn add mixpanel-browser react-mixpanel ``` then replace src/App.js with this ``` import React, {Component} from 'react'; import mixpanel from 'mixpanel-browser'; import MixpanelProvider from 'react-mixpanel'; mixpanel.init('831c108f9cb2220b0e431bbb7f97493c'); class App extends Component { render() { return ( <MixpanelProvider mixpanel={mixpanel}> <div>hi</div> </MixpanelProvider> ); } } App.contextTypes = { mixpanel: PropTypes.object.isRequired }; export default App; ```

…

On Fri, Dec 22, 2017 at 8:25 PM, Tomasz Netczuk ***@***.***> wrote: Yup it seems to be problem with create-react-app/eslint. Please provide minimal working example of the error so I can help further! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#10 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEoOT5miYM-_dFt5fybcT5-a0g8b8mzks5tDAIsgaJpZM4RH7eL> .

[neciu]

Since I released the new version of the module, that requires React >= 16.3 - I'm closing the issue.