Unexpected ReactNativeStyleResolver module missing ?
Closed this issue · 3 comments
momsse commented
The problem
The module packages/react-native-web/src/exports/StyleSheet/ReactNativeStyleResolver.js have been deleted on this commit: Fix copyright headers
I guess it's a bad move given the commit message?
That actualy break injection of react-native-web on react-primitives lib (see here)
Could not find module in path: 'react-native-web/dist/cjs/exports/StyleSheet/ReactNativeStyleResolver' relative to '/node_modules/react-primitives/lib/injection/react-native-web.js'
How to reproduce
Simplified test case: https://codesandbox.io/s/618w52082r
Steps to reproduce:
- Just go to the landing page of https://codesandbox.io/s/618w52082r
Expected behavior
No crash.
Environment (include versions). Did this work in previous versions?
- React Native for Web (version):
0.12 - React (version):
16 - Browser: TBC
necolas commented
Someone needs to patch react primitives
ljharb commented
Removing a file is still a breaking change; in this case done in a minor version.
necolas commented
And pre-1.0.0 that should be expected. Plus primitives is using a private API