Multiple issue with Settings dialog.
Paulls20 opened this issue · 10 comments
Multiple issue with Settings dialog.
- Many Settings dialog can be opened at the same time.
- Settings dialog is not closed even after the application is closed.
- Sometimes the application crashes when Settings dialog is closed.
- Typo value) in a button in Settings dialog.
Yeah, this is what I'm currently working on.
- The multiple settings dialog is a mistake, although the functionality differs on macOS against other OS's, under macOS the normal behaviour is that the window is not modal, under Linux and Windows it should be modal.
- Related to 1, I'll fix.
- Are you able to share instructions for repeating or any debug info?
- I'll fix.
Steps to reproduce the crash:
fish: Job 2, “/home/paul/Workspace/pingnoo/bi…” terminated by signal SIGSEGV (Address boundary error)
Thanks, I will take a look. I have fixed 1 & 2. I cannot see the typo (sorry), where exactly is it?
Ok found it, it's on Windows/Linux.
What OS version are you getting the crash on, I can't repeat it here.
Also loving your terminal prompt!
(Thanks for the video, that's a super helpful way of providing feedback).
Fixes for 1,2 & 4 have been pushed.
It's not exactly a typo, but an extra closing bracket.
What OS version are you getting the crash on, I can't repeat it here.
Also loving your terminal prompt!
(Thanks for the video, that's a super helpful way of providing feedback).
I'm using ubuntu 20.04
Ok, I can repeat under 20.04!
item 3 (crash on close) is now fixed.
Just a small note, I still have to finish up some of the settings dialog, the hostmaskers section is mostly working, but the other pages need hooking up to persistent settings, I will fix this in the next couple of days.