Broke "DS4Windows" mode in DsHidMini
Closed this issue · 8 comments
Regression reported by @Kanuan that wireless DS4Windows mode on DsHidMini broke wit the refactoring changes.
@Kanuan is 04:98:F3:91:3F:CE the MAC address of the controller you tested with? Can you please confirm, thanks.
yes
What an odd issue indeed, I have fixed the Device ID format in my local test build but it still doesn't work 🤔
I'll focus on the crash-relevant fixes and then come back to this once I have a new production signed copy I can then debug directly with DS4Windows.
Found it. DS4Windows checks if a detected controller is a virtual device to exclude them from detection and it so happens that the current check now also triggers on the DS3:
The check basically tries to read the "UI number" device property and assumes it's a virtual device if the value is populated.
Thinking on what's the best way to fix this, IMHO the detection in DS4Windows should be patched since this check method is very brittle to begin with. More to come.
Success!
Preparing PR.
The fix has been merged into DS4Windows 🥳 Now we wait for a new release ☕