Compilation failure due to reference to crypto module
Closed this issue · 4 comments
This is a weird one that manifests as a 404 request to http://localhost:8000/__wds-outside-root__/6/__web-dev-server__/rollup/node-resolve:empty.js?web-dev-server-rollup-null-byte=%00node-resolve%3Aempty.js
I was able to track this down to an import of the (deprecated) nodejs crypto module. Does not appear in the package manifest or lockfile. Very odd. Potentially due to @holochain/client's import of tweetnacl. I'm working through updating the client libs to see if this resolves the issue as I currently have two versions of @holochain/client being loaded, and the more recent one (coming from @vf-ui/graphql-client-holochain) is probably the more correct one.
Hmm, lots to coordinate here. It seems that @neighbourhoods/sensemaker-lite-types also depends on an older @holochain/client.
@weswalla are you already working through these updates? If so I can wait...
Actually sorry ignore that, looks like you already dealt with the types repo in 0.1.0 and I just needed to update that version here. @neighbourhoods/nh-we-applet and all of the @holochain-open-dev packages were suffering a similar issue and also needed to be updated.
@holochain-open-dev/cell-client is still a problem and references "@holochain/client": "^0.10.2".
Interestingly I am not hitting this with #7 anymore, even though @vf-ui/vf-graphql-holochain still depends on @holochain/client@0.11.9, which has tweetnacl (and crypto) as a dependency (this has been the case since 0.10.0).
It may be the case that some configuration between the WDS (now removed in #7) and Rollup development tooling regarding nodejs builtins was causing this issue.
Will leave this open until #7 is merged and confirmed working as we still have some decisions to make there.