neiman-marcus/serverless-provisioned-concurrency-autoscaling

Configuration schema extension does not pass strict validation mode

pgrzesik opened this issue ยท 4 comments

Hello,

along with the upcoming v3 release of the Serverless Framework, internal schema validation has been improved and now enforces strict validation mode. Unfortunately, after preliminary tests, it seems like the schema extension implemented in this plugin does not adhere to strict validation rules and needs to be adjusted in order to support v3 release of the Framework. The best way to verify that is to use the plugin along with the latest v3 prerelease (or official release soon).

I'm happy to answer any additional questions.

@pgrzesik Thank you for bringing this to our attention. Do you mind forwarding us the docs that would support strict validation for v3? I am not able to find it.

Hello @claydanford ๐Ÿ‘‹ There's no specific Framework docs, but in v3 we upgraded ajv to v8 and enforced strict schema validation with the following settings:

strict: true,
strictRequired: false,

The best information about what that means can be found here: https://ajv.js.org/strict-mode.html

Honestly, the best way to address it is to just try to run plugin with v3 Framework and see the error that will pop up - as the plugin only adds a few properties it should be quite easy to address.

If you have any additional questions please let me know ๐Ÿ’ฏ

@pgrzesik Thanks for the feedback. It worked as you said. I opened #29 to resolve.

Happy to hear that @claydanford ๐Ÿ™Œ Thanks for addressing it so quickly ๐Ÿ™‡