nek023/Lin-Xcode5

Localizable.strings can't contain comments

Opened this issue · 2 comments

FredTheBishop commented

Fails to properly parse existing entries in Localizable.strings files that contain comments.

Patch LNLocalizationCollection.m, reloadLocalizations:

  1. regular expression ending ";$ better ending ";(.*)$ to allow any characters after terminator, before line ending.
  2. change the line:
    if (result.range.location != NSNotFound && result.numberOfRanges == 5) {
    to:
    if (result.range.location != NSNotFound && result.numberOfRanges >= 5) {
    because firstMatchInString: may return a range (no. 6) for the comments.
Ziewvater commented

Put your code changes into a pull request. Fixes indexing issues with comments following ";"
#30

marchv commented

I have forked the plug-in and made my own support for comments including the UI. Please check #32 or https://github.com/marchv/Lin-Xcode5. Please note that the comments are expected to be on the previous line:

/* My 1st comment */
"my1stKey" = "My 1st string";

/* My 2nd comment */
"my2ndKey" = "My 2nd string";

Feedback is welcome :)