Consider using a dynamic config.json to handle settings

Question

Consider using a dynamic config.json to handle settings

KNOXDEV opened this issue 5 years ago · 6 comments

I think requiring CLI arguments to function properly is not an ideal configuration strategy for what essentially amounts to a service. I propose the following:

Eliminate all command line arguments except one: --config that will allow you to declare the location of config.json dynamically
If the config argument above is not passed, fall back to some POSIX-y default, like ~/.andesite/config.json
Move all previous command line settings into config.json

This strategy is very typical for applications of this nature.

Answer 1 · 2019-06-04T22:42:47.000Z

I forgot to mention that I did see Issue #26, but I'm not sure what the status is on that endeavor, this issue proposes a different solution entirely, and I believe this offers a better alternative.

Answer 2 · 2019-06-04T22:49:22.000Z

I recently added --use-home true which places the config.json inside of ~/.config/andesite/. Is this a suggestion to also be able to set --root, --port, and others from inside the config file? Just clarifying before I move forward.

Answer 3 · 2019-06-04T22:57:17.000Z

Actually, --use-home is going to be removed and it will auto fallback to ~/.config/andesite/ if /.andesite/ is not found in --root.

Answer 4 · 2019-06-04T23:03:11.000Z

Also, #26 was originally created to be used in conjunction with eventual Docker support and not manual usage. Though people would be free to do so.

Answer 5 · 2019-06-04T23:07:17.000Z

Yeah, any options that CAN be configured from the config file should definitely be designated to it, it allows much more consistency for the person configuring and greater freedom to extend those options in the future. It also simplified the process of configuring andesite to be launched as a service using Linux’s systemd or Windows Services.

…

On Jun 4, 2019, at 3:49 PM, Meghan Denny ***@***.***> wrote: I recently added --use-home true which places the config.json inside of ~/.config/andesite/. Is this a suggestion to also be able to set --root, --port, and others from inside the config file? Just clarifying before I move forward. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

Answer 6 · 2019-06-05T06:42:10.000Z

The Andesite executable can now be launched with no CLI arguments and is able to read all config info from the respective properties inside ~/.config/andesite/config.json.