nemerosa/versioning

Unable to use 3.0.0 with JDK 8

szpak opened this issue · 5 comments

szpak commented

Spock uses your plugin and recently (thanks to Dependabot), we discovered that 3.0.0 requires JDK 11 (and Spock is still compatible with JDK8+).

Looking at the commits it seems to be done accidentally in:
5b7a509

If yes, you should set sourceCompatibility = '8' or use a modern counterpart:
https://docs.gradle.org/current/userguide/building_java_projects.html

dcoraboeuf commented

Hi, support for Jdk 11 is no accident. It's been done to support the latest version of some dependencies like JGit.

Hence the change of major version number to indicate the incompatible change.

If your code depends on Jdk 8, I suggest you keep to the 2.x version.

Best regards, Damien

szpak commented

Ok. In that case, you could document (e.g. in README or in the release notes) that fact to avoid confusion and reports like that.

dcoraboeuf commented

It's documented in change log accessible from the readme

szpak commented

Ok, I have found it.

Maybe you could also put a link to wiki on the release page:
image

szpak commented

Btw, you could set sourceCompatibility in your build.gradle.kts anyway to make it clear. Currently, once build with JDK 17, it would be the required JDK version (not 11). Of course, having it automatically released from CI mitigate the problem (unless you accidentally bump the build image version :-) ).